🚮 Eliminate elementName method #27470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's equivalent to the Element's `localName` in every case we care about. Also eliminates a bit of constructor cruft from the CEv0 days.
kristoferbaxter
approved these changes
Mar 30, 2020
| self = super(self); | ||
| self.createdCallback(); | ||
| return self; | ||
| /** */ |
There was a problem hiding this comment.
Does something complain when removing this empty comment?
Excellent question, and one I hadn't tested. Thankfully, IE11 does the right thing and reports the lowercased name, like all the other browsers. |
This was referenced Apr 8, 2020
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Apr 15, 2020
This is a continuation of ampproject#25245. All of our Custom Elements extend from a common `CustomAmpElement` class, which itself extends from `HTMLElementPolyfill`. In ampproject#27470, I removed the `constructor` from `CustomAmpElement` class. But, because it's a subclass and must have a `constructor` that calls `super()`, Closure replaced it with a `constructor() { superClass.apply(this, arguments); }` when transpiling. But, due to the same faulty inheritance chain described in ampproject#25245, `HTMLElementPolyfill` doesn't inherit an `apply` method! So doing `superClass.apply()` throws an error. 😭 This PR installs all important Function methods onto our polyfill, to be resilient to any future changes in the instance creation.
calebcordry
added a commit
that referenced
this pull request
Apr 27, 2020
This reverts commit fc69bcf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's equivalent to the Element's
localNamein every case we care about. Also eliminates a bit of constructor cruft from the CEv0 days.